[llvm-commits] [compiler-rt] PATCH: asan_interceptors.cc: strncmp does not call ENSURE_ASAN_INITED();

[Kostya Serebryany]

Hi Nick,
Thanks for the bug report!
I've submitted r160853 which fixes both strcmp and strncmp.

On Fri, Jul 27, 2012 at 12:57 AM, Nick Kralevich <nnk at google.com> wrote:

> I filed http://code.google.com/p/address-sanitizer/issues/detail?id=94,
> but I was told that this mailing list is a better place to submit
> patches.
>

Either one is fine.

--kcc


>
> If ASAN's strncmp function is called early enough in a program's
> lifecycle, ASAN will segfault. This is due to ASAN's strncmp not
> calling ENSURE_ASAN_INITED().  More details are in the bug above.
>
> A 1 line patch is attached which resolves this issue.
>
> A similar bug is present in ASAN's strcmp function.  It too does not
> call ENSURE_ASAN_INITED().  It's not clear to me whether this is
> intentional or not.
>
> -- Nick
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120727/2a74dcef/attachment.html>