[llvm-commits] [PATCH][MCJIT] Removing DefaultJITMemoryManager from MCJITMemoryManager

[Kaylor, Andrew]

It seems like a bad idea to start requiring a non-NULL JMM.  It wasn't long ago that the reference implementations like lli were leaving that NULL, and I believe that for small objects it works.  That said, I do think something needs to be done to get a better default behavior for MCJIT.

Did you happen to see my recent proposal for MCJIT enhancements?

-Andy

From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Danil Malyshev
Sent: Wednesday, July 25, 2012 5:18 PM
To: llvm-commits at cs.uiuc.edu
Subject: [llvm-commits] [PATCH][MCJIT] Removing DefaultJITMemoryManager from MCJITMemoryManager

Hi everyone,


Please review attached the patch.
The MCJITMemoryManager shouldn't use the DefaultJITMemoryManager by following reason:
1. It does not have any methods for invalidating instruction cache, so attempt to execute the code might be fail in ARM platforms.
2. The repeated call of DefaultJITMemoryManager.allocateDataSection() fails.
But the MCJITMemoryManager misleading because his constructor create the DefaultJITMemoryManager if jmm parameter is empty. This patch fixed it.


Regards,
Danil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120726/487ea6f7/attachment.html>