[llvm-commits] [lld] r160732 - /lld/trunk/lib/ReaderWriter/ELF/ReaderELF.cpp

[Sid Manning]

On 07/25/12 20:10, Nick Kledzik wrote:
> Sid,
>
> Please compile with -Wshadow.   ReaderELF.cpp produces a bunch of shadow
variable warnings, usually two local variables in scope with the same name.
Ok that produced a lot of warnings but I think I got rid of all the ones 
that surfaced from ReaderELF.cpp

>
> Also, we want Readers to cleanly return with an error_code if an errors
occur.   This is so that the Readers can be used as a library in some other
program (such as an IDE). The ReaderELF currently calls
llvm::report_fatal_error() which usually terminates the program.
>
No problem, I follow what ReaderCOFF does and return letting EC be dealt 
with by the caller.

The patch is attached.

Thanks,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ReaderELF.cpp.diff
Type: application/octet-stream
Size: 3382 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120726/259143a9/attachment.obj>