[llvm-commits] [PATCH] [MIPS] Avoid use of __builtin_unreachable() when compiling LLVM for MIPS.

[Duncan Sands]

Hi Reed,

On 25/07/12 13:11, Reed Kotler wrote:
> On 07/25/2012 04:07 AM, Duncan Sands wrote:
>> Hi Reed,
>>
>>> Not everyone does "make check" so it's better to just not let them build the
>>> compiler in the first place.
>>
>> someone who doesn't do "make check" yet nonetheless uses LLVM for something
>> important deserves what they get IMO.
>>
> Agreed... but people do and also there can be known failures and someone has to
> know how to sort out what it all means and at the end of the day, Mips can be
> blamed for things not working if someone can build a working compiler and then
> it has issues.

if Mips doesn't want to be blamed when people build LLVM with a random compiler
and it doesn't work right then Mips is in trouble, because failures will happen
(bugs are reported regularly in LLVM bugzilla that are caused by miscompilation
of LLVM/clang by random compiler XYZ on funky system ABC).  I reckon the best
you can do is clearly document somewhere some known working setups (a particular
LLVM revision, a particular host compiler and system etc), document known not
working setups, suggest a validation procedure for people who don't want to use
the known good version(s) [you should make sure that validation will fail for
all known bad setups eg due to "make check" failing], and provide a simple way
for people to let you know about new bad versions they discover (eg: explain
that problems should be reported in LLVM bugzilla with the MIPS tag, and ensure
that you automatically get sent a copy of all such bugs).

Ciao, Duncan.