[llvm-commits] [compiler-rt] r160669 - /compiler-rt/trunk/lib/asan/CMakeLists.txt

[Alexey Samsonov]

On Wed, Jul 25, 2012 at 12:31 PM, Chandler Carruth <chandlerc at google.com>wrote:

> I think fundamentally this is the right approach, but figuring out Clang's
> version number is pretty gross.
>
> Can you add a clear FIXME that we should switch to re-use the Clang cmake
> build's information?
>
> Also, you should document the use case and behavior for the other generic
> bits of the patch to support building clang runtime libraries and dropping
> them into the appropriate location.
>

r160721



>
>
> On Tue, Jul 24, 2012 at 7:06 AM, Alexey Samsonov <samsonov at google.com>wrote:
>
>>
>>
>> On Tue, Jul 24, 2012 at 3:59 PM, Alexey Samsonov <samsonov at google.com>wrote:
>>
>>>
>>>
>>> On Tue, Jul 24, 2012 at 3:53 PM, Chandler Carruth <chandlerc at google.com>wrote:
>>>
>>>> On Tue, Jul 24, 2012 at 4:49 AM, Alexey Samsonov <samsonov at google.com>wrote:
>>>>
>>>>> Author: samsonov
>>>>> Date: Tue Jul 24 06:49:55 2012
>>>>> New Revision: 160669
>>>>>
>>>>> URL: http://llvm.org/viewvc/llvm-project?rev=160669&view=rev
>>>>> Log:
>>>>> [ASan] hacking cmake build
>>>>
>>>>
>>>> No, this is completely incorrect. Please get review beforehand if
>>>> you're not confident in a patch.
>>>>
>>>> CMake has specific infrastructure to manage installing files if you
>>>> want this to happen during install.
>>>>
>>>> If you just want the directory layout of the build tree to Just Work
>>>> (which makes sense) you should setup the paths so the libraries go into the
>>>> correct place to begin with, not copy them there after-the-fact.
>>>>
>>>
>>> Should I setup the build path for static runtime libs like this:
>> http://codereview.appspot.com/6436051/ ?
>>  All runtimes would have to be placed in lib/clang/3.2/... (not only ASan
>> runtime).
>>
>> --
>> Alexey Samsonov, MSK
>>
>>
>


-- 
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120725/3ce30e18/attachment.html>