[llvm-commits] [PATCH] [MIPS] Avoid use of __builtin_unreachable() when compiling LLVM for MIPS.

[Duncan Sands]

Hi Petar,

> as I mentioned in the previous email, the bug report I pasted link for was the original root cause. There seem to be more issues caused by __builtin_unreachable, and toolchains that have a fix for that one (for instance latest Google 4.6.x toolchain for Android) still have issues with __builtin_unreachable for MIPS.
>
> We will inevitably resolve all these issues (we are debugging the latest occurrence now), but until that point is reached, we need to compile LLVM correctly.

if this is a question of "make llvm_unreachable more friendly while we fix the
MIPS backend" why not just apply your change locally rather than in the main
repository?  That said, I personally think it was a mistake to replace
assert(false) with llvm_unreachable in places that may be reachable but
shouldn't happen.

Ciao, Duncan.