[llvm-commits] [llvm] r160687 - in /llvm/trunk: lib/Target/X86/X86ISelDAGToDAG.cpp test/CodeGen/X86/gs-fold.ll

[Rafael Espíndola]

thanks!

On 24 July 2012 16:04, David Chisnall <csdavec at swan.ac.uk> wrote:
> Author: theraven
> Date: Tue Jul 24 15:04:16 2012
> New Revision: 160687
>
> URL: http://llvm.org/viewvc/llvm-project?rev=160687&view=rev
> Log:
> ELF does not imply GNU/Linux.  Do not assume GNU conventions just because we
> are targeting an ELF platform.  Only fold gs-relative (and fs-relative) loads
> if it is actually sensible to do so for the target platform.
>
> This fixes PR13438.
>
>
> Added:
>     llvm/trunk/test/CodeGen/X86/gs-fold.ll
> Modified:
>     llvm/trunk/lib/Target/X86/X86ISelDAGToDAG.cpp
>
> Modified: llvm/trunk/lib/Target/X86/X86ISelDAGToDAG.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelDAGToDAG.cpp?rev=160687&r1=160686&r2=160687&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/X86/X86ISelDAGToDAG.cpp (original)
> +++ llvm/trunk/lib/Target/X86/X86ISelDAGToDAG.cpp Tue Jul 24 15:04:16 2012
> @@ -593,7 +593,7 @@
>    // For more information see http://people.redhat.com/drepper/tls.pdf
>    if (ConstantSDNode *C = dyn_cast<ConstantSDNode>(Address))
>      if (C->getSExtValue() == 0 && AM.Segment.getNode() == 0 &&
> -        Subtarget->isTargetELF())
> +        Subtarget->isTargetLinux())
>        switch (N->getPointerInfo().getAddrSpace()) {
>        case 256:
>          AM.Segment = CurDAG->getRegister(X86::GS, MVT::i16);
>
> Added: llvm/trunk/test/CodeGen/X86/gs-fold.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/gs-fold.ll?rev=160687&view=auto
> ==============================================================================
> --- llvm/trunk/test/CodeGen/X86/gs-fold.ll (added)
> +++ llvm/trunk/test/CodeGen/X86/gs-fold.ll Tue Jul 24 15:04:16 2012
> @@ -0,0 +1,20 @@
> +; RUN: llc < %s -mtriple=x86_64-unknown-freebsd | FileCheck %s --check-prefix=CHECK-FBSD
> +; RUN: llc < %s -mtriple=x86_64-unknown-linux | FileCheck %s --check-prefix=CHECK-LINUX
> +target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128"
> +
> +%struct.thread = type { i32, i32, i32, i32 }
> +
> +define i32 @test() nounwind uwtable {
> +entry:
> +  %0 = load volatile %struct.thread* addrspace(256)* null
> +  %c = getelementptr inbounds %struct.thread* %0, i64 0, i32 2
> +  %1 = load i32* %c, align 4
> +  ret i32 %1
> +}
> +
> +; Check that we are not assuming that gs contains the address of gs if we are not targeting Linux
> +; CHECK-FBSD: movq     %gs:0, %rax
> +; CHECK-FBSD: movl     8(%rax), %eax
> +; Check that we are assuming that gs contains the address of gs if we are targeting Linux
> +; CHECK-LINUX: movl    %gs:8, %eax
> +
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits