[llvm-commits] PATCH: lld ReaderELF.cpp update

Michael Spencer bigcheesegs at gmail.com
Mon Jul 23 15:07:13 PDT 2012


On Mon, Jul 23, 2012 at 2:03 PM, Nick Kledzik <kledzik at apple.com> wrote:
> Michael,
>
> What is the status of the Windows file mapping layer?   My high level FileOutputBuffer has been blocked awhile waiting your work on making the lower level map_file_pages() work on Windows.  Last I heard, you said you would need to change the API to map_file_pages().
>
> Can I go ahead and commit FileOutputBuffer that works on Darwin/Unix, as long as it should compile on Windows (but not run), with the unit tests conditionalized away (for now). Then you can get a Windows implementation working, perhaps changing map_file_pages and FileOutputBuffer to do so?

This is fine with me.

- Michael Spencer

>
> -Nick
>
> On Jul 20, 2012, at 9:52 AM, Sid Manning wrote:
>> In looking at, WriterMachO.cpp the first thing I noticed was it depended on FileOutputBuffer but there is a patch out there for it so I will pull that in and see how it works.
>




More information about the llvm-commits mailing list