[llvm-commits] [llvm] r160556 - /llvm/trunk/utils/lit/lit/TestRunner.py

[Daniel Dunbar]

Author: ddunbar
Date: Fri Jul 20 13:29:34 2012
New Revision: 160556

URL: http://llvm.org/viewvc/llvm-project?rev=160556&view=rev
Log:
lit: Use close_fds=True on UNIX, to avoid file descriptor pollution of
subprocesses.

Modified:
    llvm/trunk/utils/lit/lit/TestRunner.py

Modified: llvm/trunk/utils/lit/lit/TestRunner.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/TestRunner.py?rev=160556&r1=160555&r2=160556&view=diff
==============================================================================
--- llvm/trunk/utils/lit/lit/TestRunner.py (original)
+++ llvm/trunk/utils/lit/lit/TestRunner.py Fri Jul 20 13:29:34 2012
@@ -24,11 +24,15 @@
 kAvoidDevNull = kIsWindows
 
 def executeCommand(command, cwd=None, env=None):
+    # Close extra file handles on UNIX (on Windows this cannot be done while
+    # also redirecting input).
+    close_fds = not kIsWindows
+
     p = subprocess.Popen(command, cwd=cwd,
                          stdin=subprocess.PIPE,
                          stdout=subprocess.PIPE,
                          stderr=subprocess.PIPE,
-                         env=env)
+                         env=env, close_fds=close_fds)
     out,err = p.communicate()
     exitCode = p.wait()