[llvm-commits] Patch to unify same code in multiple spots

[Villmow, Micah]

> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> bounces at cs.uiuc.edu] On Behalf Of NAKAMURA Takumi
> Sent: Friday, July 20, 2012 1:20 AM
> To: Duncan Sands
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [llvm-commits] Patch to unify same code in multiple spots
> 
> Duncan,
> 
> 2012/7/20 Duncan Sands <baldrick at free.fr>:
> > how about having the factorized function return the calling convention
> > name as a const char *, since that's more general, and then do
> >    Out << getCallingConvName(F->getCallingConv());
> > etc.
> 
> I thought it would be better idea, unless we had a form of "cc###".
[Villmow, Micah] Yep, this would normally work except for the case of unknown calling convention, which is exactly how I found this code in multiple spots.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits