[llvm-commits] [llvm] r156714 - in /llvm/trunk: lib/MC/MCParser/AsmParser.cpp test/MC/AsmParser/macro-rept-err1.s test/MC/A

[PaX Team]

On 19 Jul 2012 at 21:19, Zhang, Andy wrote:

Hi Andy,

> I have a patch for space-delimited arguments, that incorporates your
> changes for default parameter values and error message improvements,
> that can parse obvious expressions (eg, "a - b"). I also fixed the
> assertion failure when parsing ".if ($0) != ($1)" on non-Darwin in
> your patch. 
> 
> I think we can get the best of both worlds this way :)

i don't have any particular feeling about space delimited arg handling,
my only goal was to get integrated-as to work on linux (the kernel)
itself. so as long as your changes preserve that ability and keep the
rest of my changes that i think clean up existing code, i'm all for it :).
also note that i'm not a decision maker at all here, you'll probably
have to discuss these changes with Rafael and others.