[llvm-commits] AMDIL backend first patches

[Oliveira, Victor]

ok, I think it's better now.

Victor

________________________________
From: Owen Anderson [resistor at mac.com]
Sent: Tuesday, July 17, 2012 12:31 PM
To: Oliveira, Victor
Cc: llvm-commits at cs.uiuc.edu LLVM; Villmow, Micah; Bridgman, John
Subject: Re: [llvm-commits] AMDIL backend first patches

Hi Victor,

I like the concept of your PassManager debugging patch, but I'd like to see it provide a little bit more useful output.  As it is, only someone who has looked at this code is going to be able to tell what the output means.  Perhaps add some annotations in the output and/or a useful error message when AnalysisPass2 is null.  A good use case to keep in mind is "would this output be useful to an LLVM developer who hasn't looked at the logging code, and is trying to track down an error?"

--Owen


On Jul 13, 2012, at 1:37 PM, "Oliveira, Victor" <Victor.Oliveira at amd.com<mailto:Victor.Oliveira at amd.com>> wrote:

Hi!

I'm Victor Oliveira and I'm an intern at AMD. I've been working last weeks to upstream the most we can of our AMDIL backend in LLVM.

These first two patches are changes that we have made in LLVM Core. They consist of a MachinePostDominator pass and a change in PassManager to have some diagnostic information for debugging incorrect pass setup.

As soon we finish our internal review process I'll send the remaining patches with the AMDIL backend.

Thanks a lot,
Victor Oliveira

<0001-Including-a-MachinePostDominator-pass.patch><0002-Adding-some-debug-information-to-PassManager.patch>_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120717/2a4f5a99/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Adding-some-debug-information-to-PassManager.patch
Type: text/x-patch
Size: 1861 bytes
Desc: 0002-Adding-some-debug-information-to-PassManager.patch
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120717/2a4f5a99/attachment.bin>