[llvm-commits] [llvm] r156714 - in /llvm/trunk: lib/MC/MCParser/AsmParser.cpp test/MC/AsmParser/macro-rept-err1.s test/MC/A

[Zhang, Andy]

PaX,

Actually, I didn't notice your patch changed exprs.s to run only for Darwin. Was that intentional? There is an assertion failure if you try to run that test with "-triple i386-unknown-unknown":

lib/MC/MCParser/AsmParser.cpp:553: virtual bool {anonymous}::AsmParser::Run(bool, bool): Assertion `HadError && "Parse statement returned an error, but none emitted!"' failed.


- Andy

> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> bounces at cs.uiuc.edu] On Behalf Of Zhang, Andy
> Sent: Tuesday, July 17, 2012 1:37 PM
> To: pageexec at freemail.hu; llvm-commits at cs.uiuc.edu 
<snip>
> Any idea why exprs.s is only being tested for Darwin?
> 
> - Andy
> > -----Original Message-----
> > From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> > bounces at cs.uiuc.edu] On Behalf Of PaX Team
> > Sent: Tuesday, July 10, 2012 9:25 AM
> > To: Rafael Espíndola
> > Cc: llvm-commits at cs.uiuc.edu
> > Subject: Re: [llvm-commits] [llvm] r156714 - in /llvm/trunk:
> > lib/MC/MCParser/AsmParser.cpp test/MC/AsmParser/macro-rept-err1.s
> > test/MC/A
> >
> > On 14 May 2012 at 19:12, Rafael Espíndola wrote:
> >
> > Hi Rafael,
> >
> > first of all, thank you for taking in most of the patches, i've just
> > been very busy with other stuff and didn't have time to follow up so
> > far. here i'd like to resubmit the missing and probably biggest part
> > related to macro handling. it's a straightforward port from the
> > previous submission, but with other pieces already in the tree,
> > hopefully it's easier to digest ;).
> >
> > > Can you add testcases showing that the nesting works? Nesting with
> > > .macro in particular.
> >
> > right now make check fails to run at all here, so i didn't add these
> > tests yet, maybe somebody has an idea? this is what i get:
> >
> > Making LLVM 'lit.site.cfg' file...
> > sed: file lit.tmp line 8: unknown option to `s'
> > make[1]: *** [lit.site.cfg] Error 1
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits