[llvm-commits] [llvm] r156714 - in /llvm/trunk: lib/MC/MCParser/AsmParser.cpp test/MC/AsmParser/macro-rept-err1.s test/MC/A

[PaX Team]

On 12 Jul 2012 at 10:17, Rafael Espíndola wrote:

Hi,

> Two quick first comments:
> 
> * Why you went back to passing SmallString<256>&?

i meant it as not so much as 'going back' but simplification because (imho) the only
real place where the stream interface adds some readability value is inside expandMacro
itself, its callers don't really care since they just need to append a single word. in
any case, i can keep using raw_svector_ostream if that's the preferred way.

> * Can you put the typedefs and whitespaces in a first trivial patch?

sure but it'll have to wait a bit as i don't have much free time left for llvm these days
(maybe the llvmlinux folks want to chime in at this point ;).

cheers,
  PaX Team