[llvm-commits] [llvm] r160055 - /llvm/trunk/lib/Target/X86/X86FastISel.cpp

[Eric Christopher]

I think I'd almost rather leave the unreachable as the default and add anything that's missing (with possibly a TODO).

Your thoughts?

-eric

On Jul 11, 2012, at 10:23 AM, Chad Rosier <mcrosier at apple.com> wrote:

> Author: mcrosier
> Date: Wed Jul 11 12:23:17 2012
> New Revision: 160055
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=160055&view=rev
> Log:
> [x86 fast-isel] Rather then call llvm_unreachable() have fast-isel fall back
> to Selection DAG isel.  Patch by Andrew Kaylor <andrew.kaylor at intel.com>.
> 
> Modified:
>    llvm/trunk/lib/Target/X86/X86FastISel.cpp
> 
> Modified: llvm/trunk/lib/Target/X86/X86FastISel.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86FastISel.cpp?rev=160055&r1=160054&r2=160055&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/X86/X86FastISel.cpp (original)
> +++ llvm/trunk/lib/Target/X86/X86FastISel.cpp Wed Jul 11 12:23:17 2012
> @@ -1693,7 +1693,7 @@
> 
>     // Promote the value if needed.
>     switch (VA.getLocInfo()) {
> -    default: llvm_unreachable("Unknown loc info!");
> +    default: return false;
>     case CCValAssign::Full: break;
>     case CCValAssign::SExt: {
>       assert(VA.getLocVT().isInteger() && !VA.getLocVT().isVector() &&
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits