[llvm-commits] [PATCH] Proper treatment of unhandled CCValAssign cases in X86FastISel.cpp

[Duncan Sands]

Hi Andy,

> I came across a case today where the X86 fast instruction selector was throwing
> an llvm_unreachable error in response to a valid value for an argument location
> (CCValAssign::Indirect in the case I ran into).  I don’t know if it would be
> reasonable to handle this case in the X86FastISel code, but in the meantime it
> seems the code should simply return ‘false’ when it encounters an unimplemented
> location type so that the SelectionDAG can handle it.
>
> The attached patch does that.

what's the testcase?

Ciao, Duncan.