[llvm-commits] [llvm] r160002 - in /llvm/trunk: include/llvm/CodeGen/MachineFrameInfo.h lib/Target/X86/X86FrameLowering.cpp lib/Target/X86/X86RegisterInfo.cpp lib/Target/X86/X86RegisterInfo.h test/CodeGen/X86/alloca-align-rounding-32.ll test/Code

[Chad Rosier]

On Jul 10, 2012, at 10:58 AM, Anton Korobeynikov wrote:

> Hi Chad,
> 
> Sorry, I was not ato review your patch earlier.

No problem; your previous feedback has been very helpful.

>> +  /// After the stack pointer has been restore from the base pointer we
>> +  /// use a cached adjusment.  Currently only used for x86.
>> +  int64_t BPAdj;
> Can't you store this into local MachineFunctionInfo ?

Do you mean the X86MachineFrameInfo?  If so, sure.

> PS: Please make sure that unwinding is done properly through functions
> with realigned stack.

I surely haven't forgotten.  I'll mull this over for a bit and see if I can't figure out a way to test this functionality.

 Chad

> -- 
> With best regards, Anton Korobeynikov
> Faculty of Mathematics and Mechanics, Saint Petersburg State University