[llvm-commits] Please review the patch for IntegersSubsetMapping

[Duncan Sands]

Hi Stepan,

On 07/07/12 18:53, Stepan Dyatkovskiy wrote:
> ping.

I would like to see a discussion and review of the entire approach you are
taking, before getting to the level of discussing individual patches.  I
thought I knew where you were going, but your patches don't seem to be going
there.  Maybe that's just because I don't understand them: they seem strangely
complicated, over-engineered, and I get lost in a mass of templates and other
abstractions.  In my opinion it would be best to do things in a simple, direct
way with very little attempt to abstract concepts out.  Premature abstraction
is harmful.

Ciao, Duncan.