[llvm-commits] [llvm] r159707 - in /llvm/trunk/lib/DebugInfo: DWARFCompileUnit.cpp DWARFCompileUnit.h

[Chandler Carruth]

On Thu, Jul 5, 2012 at 4:14 AM, Alexey Samsonov <samsonov at google.com> wrote:

>
>
> On Thu, Jul 5, 2012 at 2:22 AM, Nick Lewycky <nicholas at mxc.ca> wrote:
>
>> Bill Wendling wrote:
>>
>>> On Jul 4, 2012, at 2:42 AM, Alexey Samsonov wrote:
>>>
>>>  Author: samsonov
>>>> Date: Wed Jul  4 04:42:54 2012
>>>> New Revision: 159707
>>>>
>>>> URL: http://llvm.org/viewvc/llvm-**project?rev=159707&view=rev<http://llvm.org/viewvc/llvm-project?rev=159707&view=rev>
>>>> Log:
>>>> Fix a bug in DebugInfo lib,
>>>>
>>>
>>> Please be more descriptive of *what* you're fixing and not the fact that
>>> you *are* fixing something.
>>>
>>> This isn't to single you out, Alexey. But there have been *way* too many
>>> of these types of commit messages recently. They are almost as bad as
>>> having no commit message at all.
>>>
>>
>> Also, if this is a bug fix, where's the regression test?
>>
>
> The bug happens only when function is called for the second time.
> Currently the only client of libDebugInfo is llvm-dwarfdump, which can
> never call it twice.
>

This sounds like a great place to add some direct unittests?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120705/da0531ef/attachment.html>