[llvm-commits] Directive parsing for AsmParser patch

[Medic, Vladimir]

Hi Chad,
the test is prepared and I have attached it here for you to see. The problem is that it is a part of a larger patch that implements the llvm assembler for Mips and even with the current patch it will not be fixed. The idea was to split the large patch into several smaller and to, as much as possible, split the patches into target dependent and independent parts. Now, I can either change the patches so this one would contain the test file and the necessary change in MipsAsmParser.cpp or hold this patch until the target dependent patches are accepted and there is a functional assembler parser for Mips.

Vladimir

________________________________
From: Chad Rosier [mcrosier at apple.com]
Sent: Tuesday, July 03, 2012 6:54 PM
To: Medic, Vladimir
Cc: llvm-commits at cs.uiuc.edu; Jovanovic, Petar
Subject: Re: [llvm-commits] Directive parsing for AsmParser patch

Vladimir,
You should at lease add a test case that expressed the exact fix you're trying to make.  This would ensure it doesn't regress in the future.  Beyond that I don't have any great suggestions.

 Chad

On Jun 29, 2012, at 8:19 AM, Medic, Vladimir wrote:

Hi Chad,
I have run the basic "make check-all" test suite ,LLVM SingleSource and MultiSource test suite. What sort of testing should be performed also to verify the change?

Vladimir
________________________________
From: Chad Rosier [mcrosier at apple.com<mailto:mcrosier at apple.com>]
Sent: Thursday, June 28, 2012 10:32 PM
To: Medic, Vladimir
Cc: llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>; Jovanovic, Petar
Subject: Re: [llvm-commits] Directive parsing for AsmParser patch

Vladimir,
Jim Grosbach commented that this seemed reasonable, but also suggested having a "copious" amount of testing.  What kind of testing has been done?  Please include test cases.

 Chad

On Jun 28, 2012, at 8:21 AM, Medic, Vladimir wrote:

Hi everyone,
did somebody had a chance to look at the patch provided? It is not a large change so I think it won't take much time to review it.

Thanks

Vladimir
________________________________
From: Medic, Vladimir
Sent: Tuesday, June 05, 2012 10:02 AM
To: llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
Subject: Directive parsing for AsmParser patch

Hi all,
please find attached a patch for AsmParser that enables target dependent directive parsing to hook before standard parser as discussed in:
http://old.nabble.com/Directive-parsing-for-AsmParser-td33822227.html#a33822227

Looking forward to your comments and suggestions.

Vladimir Medic

_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120704/a61fcc60/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mips_directives.s
Type: application/octet-stream
Size: 173 bytes
Desc: mips_directives.s
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120704/a61fcc60/attachment.obj>