[llvm-commits] [llvm] r159658 - /llvm/trunk/include/llvm/Support/IntegersSubsetMapping.h
Stepan Dyatkovskiy
stpworld at narod.ru
Tue Jul 3 22:48:34 PDT 2012
Well. OK. I'll do it right now.
-Stepan.
Chandler Carruth wrote:
> On Tue, Jul 3, 2012 at 1:19 PM, Anton Korobeynikov
> <anton at korobeynikov.info <mailto:anton at korobeynikov.info>> wrote:
>
> Stepan,
>
> > + void diff_single_numbers(self *LExclude, self *Intersection,
> self *RExclude,
> > + const self& RHS) {
> Will you please consider reading
> http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly
> ?
> Or at least look for function names around?
>
>
> This is egregious.
>
> Stepan, please revert, and please switch to pre-commit review until
> you're more comfortable with the coding standards of LLVM. This code
> isn't ready to be committed to trunk in its current form.
More information about the llvm-commits
mailing list