[llvm-commits] x32 psABI support for dragonegg

[Michael Liao]

On Tue, 2012-07-03 at 18:28 +0200, Duncan Sands wrote:
> Hi Michael,
> 
> > Which one? I checked with gcc-4.5.
> 
> I was referring to your very first patch, not the one you just posted.
> 
> Ciao, Duncan.

I had 2 patches (1 simple fix and another proposal). The later is not
fully verified. Anyway, how about the latest patch based on your
re-factored code?

Yours
- Michael

> 
>   Which version you tried? How about
> > that patch attached? Is there any issue to build this against older
> > versions of GCC?
> >
> > Yours
> > - Michael
> >
> >> ). But TARGET_X32 is only defined in GCC headers and we need
> >>> move the environment overrriding part into source file.
> >>
> >> Why?
> >>
> >> Ciao, Duncan.
> >>
> >>>
> >>> Yours
> >>> - Michael
> >>>
> >>>>>
> >>>>> Yours
> >>>>> - Michael
> >>>>>
> >>>>> On Tue, 2012-07-03 at 10:24 +0200, Duncan Sands wrote:
> >>>>>> Hi Michael,
> >>>>>>> Thanks for Duncan refactoring the target triple overriding code in
> >>>>>>> dragonegg. The attached patch fixes an issue in the new code where
> >>>>>>> GCC_MINOR or other gcc symbols are not included yet due to the order of
> >>>>>>> headers.
> >>>>>>
> >>>>>> GCC_MINOR isn't defined in a header, it is defined in the Makefile and provided
> >>>>>> to the compiler via -DGCC_MINOR=6.  Thus header order is irrelevant, so I don't
> >>>>>> understand what this patch is about.
> >>>>>>
> >>>>>> Ciao, Duncan.
> >>>>>>
> >>>>>>      This patch put the x86 environment overriding code into source
> >>>>>>> file to detect GCC minor revision reliably (in addition TARGET_X32 is
> >>>>>>> checked as well to work with back-ported gcc versions.)
> >>>>>>>
> >>>>>>> Please commit the patch if it seems acceptable.
> >>>>>>>
> >>>>>>> Yours
> >>>>>>> - Michael
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> _______________________________________________
> >>>>>>> llvm-commits mailing list
> >>>>>>> llvm-commits at cs.uiuc.edu
> >>>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >>>>>>>
> >>>>>>
> >>>>>>
> >>>>>> _______________________________________________
> >>>>>> llvm-commits mailing list
> >>>>>> llvm-commits at cs.uiuc.edu
> >>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >>>>>
> >>>>>
> >>>>
> >>>>
> >>>
> >>>
> >>
> >>
> >
> 
>