[llvm-commits] x32 psABI support for dragonegg

[Michael Liao]

I see your point. The root cause is that x32 psABI is supported from
gcc-4.6 (in hjl's 4.6 branch) but the official support won't wait until
4.6.x or 4.7. Check gcc minor revision may not a reliable way to detect
whether x32 is supported or not. It's better to detect TARGET_X32 as
well.

Yours
- Michael

On Tue, 2012-07-03 at 10:24 +0200, Duncan Sands wrote:
> Hi Michael,
> > Thanks for Duncan refactoring the target triple overriding code in
> > dragonegg. The attached patch fixes an issue in the new code where
> > GCC_MINOR or other gcc symbols are not included yet due to the order of
> > headers.
> 
> GCC_MINOR isn't defined in a header, it is defined in the Makefile and provided
> to the compiler via -DGCC_MINOR=6.  Thus header order is irrelevant, so I don't
> understand what this patch is about.
> 
> Ciao, Duncan.
> 
>   This patch put the x86 environment overriding code into source
> > file to detect GCC minor revision reliably (in addition TARGET_X32 is
> > checked as well to work with back-ported gcc versions.)
> >
> > Please commit the patch if it seems acceptable.
> >
> > Yours
> > - Michael
> >
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits