[llvm-commits] [llvm] r159502 - /llvm/trunk/lib/Target/X86/X86ISelDAGToDAG.cpp

[David Blaikie]

On Sat, Jun 30, 2012 at 7:18 PM, Craig Topper <craig.topper at gmail.com> wrote:
> Author: ctopper
> Date: Sat Jun 30 21:18:18 2012
> New Revision: 159502
>
> URL: http://llvm.org/viewvc/llvm-project?rev=159502&view=rev
> Log:
> Add a break to the end of case statement missed in r159501.
>
> Modified:
>     llvm/trunk/lib/Target/X86/X86ISelDAGToDAG.cpp
>
> Modified: llvm/trunk/lib/Target/X86/X86ISelDAGToDAG.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelDAGToDAG.cpp?rev=159502&r1=159501&r2=159502&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/X86/X86ISelDAGToDAG.cpp (original)
> +++ llvm/trunk/lib/Target/X86/X86ISelDAGToDAG.cpp Sat Jun 30 21:18:18 2012
> @@ -2035,6 +2035,7 @@
>        SDNode *RetVal = SelectGather(Node, Opc);
>        if (RetVal)
>          return RetVal;

For what it's worth, and I don't think this is a documented LLVM
coding convention, but usually the variable declaration is put inside
the conditional in code like this, I think.

- David

> +      break;
>      }
>      }
>      break;
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits