[llvm-commits] Directive parsing for AsmParser patch

Medic, Vladimir vmedic at mips.com
Fri Jun 29 08:19:01 PDT 2012


Hi Chad,
I have run the basic "make check-all" test suite ,LLVM SingleSource and MultiSource test suite. What sort of testing should be performed also to verify the change?

Vladimir
________________________________
From: Chad Rosier [mcrosier at apple.com]
Sent: Thursday, June 28, 2012 10:32 PM
To: Medic, Vladimir
Cc: llvm-commits at cs.uiuc.edu; Jovanovic, Petar
Subject: Re: [llvm-commits] Directive parsing for AsmParser patch

Vladimir,
Jim Grosbach commented that this seemed reasonable, but also suggested having a "copious" amount of testing.  What kind of testing has been done?  Please include test cases.

 Chad

On Jun 28, 2012, at 8:21 AM, Medic, Vladimir wrote:

Hi everyone,
did somebody had a chance to look at the patch provided? It is not a large change so I think it won't take much time to review it.

Thanks

Vladimir
________________________________
From: Medic, Vladimir
Sent: Tuesday, June 05, 2012 10:02 AM
To: llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
Subject: Directive parsing for AsmParser patch

Hi all,
please find attached a patch for AsmParser that enables target dependent directive parsing to hook before standard parser as discussed in:
http://old.nabble.com/Directive-parsing-for-AsmParser-td33822227.html#a33822227

Looking forward to your comments and suggestions.

Vladimir Medic

_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120629/d00f17bf/attachment.html>


More information about the llvm-commits mailing list