[llvm-commits] [llvm] r159299 - in /llvm/trunk: include/llvm/MC/MCELFObjectWriter.h lib/MC/ELFObjectWriter.cpp lib/MC/MCELFObjectTargetWriter.cpp lib/Target/Mips/MCTargetDesc/MipsELFObjectWriter.cpp

[Carter, Jack]

This patch was one of three to make it digestible, 159299,159301 and 159302. The latter were testable and thus contained the test case.

Jack
________________________________________
From: Eric Christopher [echristo at apple.com]
Sent: Wednesday, June 27, 2012 5:49 PM
To: Carter, Jack
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [llvm] r159299 - in /llvm/trunk: include/llvm/MC/MCELFObjectWriter.h lib/MC/ELFObjectWriter.cpp lib/MC/MCELFObjectTargetWriter.cpp lib/Target/Mips/MCTargetDesc/MipsELFObjectWriter.cpp

On Jun 27, 2012, at 3:28 PM, Jack Carter <jcarter at mips.com> wrote:

> The ELF relocation record format is different for N64
> which many Mips 64 ABIs use than for O64 which many
> if not all other target ABIs use.

May be some now, but if not could you please add a testcase or two
that ensures that you're seeing the output you expect?

llvm-objdump should be extended to handle this.

Thanks!

-eric