[llvm-commits] [RFC] Patch 1/3 for the native code compiler of Erlang

[Duncan Sands]

Hi,

>> 2. I'm bit concerned about code like "+  bool isHipeCall = (F ?
>> F->getCallingConv() == CallingConv::HiPE : false);"
> What are exactly your concerns about it?

it surely has to be wrong?  I didn't look at the code in question, but it
sounds like at the point of a call you are looking at details of the callee.
But it should always be possible to codegen a call correctly just from the
declared type of the callee, the calling convention, the actual arguments and
any attributes they may have, without looking at the called function.  That
said, I may have completely misunderstood what this is about - but it looks
like a big red flag.

Ciao, Duncan.