[llvm-commits] [LLVMdev] [Patch, RFC] Re: Adding support for explicitly specified TLS models (PR9788)

[Hans Wennborg]

On Sat, Jun 23, 2012 at 1:35 AM, Rafael Espíndola
<rafael.espindola at gmail.com> wrote:
> It is probably better to be more strict than any particular
> implementation. The description on the IL definition is all the
> optimizers have to play with. For example, documenting the possibility
> of having a small amount of initial-exec in a dso that is dlopend
> would be a bad idea, as it would prevent the compiler from lowering a
> variable to initial-exec as that might go over the limit.
>
> Something high level like:
>
>> * localdynamic: Only used from this DSO.
>> * initialexec: Will not be loaded dynamically.
>> * localexec: Will be in the executable and is only used from it.
>
> is probably OK.

I've put that in the doc. We can tweak it more after commit if necessary.

>>> And this return is dead, you can use llvm_unreachable.
>>
>> It's not dead when GV isn't a GlobalVariable. (I'm not sure that can
>> happen, though?)
>>
> Good point. Looks like it can also be an alias, but we were handling
> that only on X86 :-( I have fixed it.

Thanks!

> LGTM with the models documented.

Great! Committed r159077.

Thanks again for reviewing this.

 - Hans