[llvm-commits] [llvm] r158788 - /llvm/trunk/lib/Support/Windows/PathV2.inc

[David Blaikie]

On Tue, Jun 19, 2012 at 9:08 PM, Francois Pichet <pichet2000 at gmail.com> wrote:
> Author: fpichet
> Date: Tue Jun 19 23:08:49 2012
> New Revision: 158788
>
> URL: http://llvm.org/viewvc/llvm-project?rev=158788&view=rev
> Log:
> Unbreak the MSVC build: add return to unimplemented functions.

It might be more idiomatic to change the assert(0) to llvm_unreachable
- it's a common construct through the codebase, so I assume it works
for/silences MSVC.

>
> Modified:
>    llvm/trunk/lib/Support/Windows/PathV2.inc
>
> Modified: llvm/trunk/lib/Support/Windows/PathV2.inc
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Windows/PathV2.inc?rev=158788&r1=158787&r2=158788&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Support/Windows/PathV2.inc (original)
> +++ llvm/trunk/lib/Support/Windows/PathV2.inc Tue Jun 19 23:08:49 2012
> @@ -793,10 +793,12 @@
>  error_code map_file_pages(const Twine &path, off_t file_offset, size_t size,
>                                             bool map_writable, void *&result) {
>   assert(0 && "NOT IMPLEMENTED");
> +  return windows_error::invalid_function;
>  }
>
>  error_code unmap_file_pages(void *base, size_t size) {
>   assert(0 && "NOT IMPLEMENTED");
> +  return windows_error::invalid_function;
>  }
>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits