[llvm-commits] [PATCH] [pr12913] Have ARM ELF use correct reloc for "b" instr

[Tim Northover]

Hi Jan,

>> The condition code didn't actually matter for arm "b" instructions,
>> unlike "bl".  It should just use the R_ARM_JUMP24 reloc.
>
> Ok to commit?  Patch reattached, based on r158659

It looks correct to me. The ARM ELF ABI says that a linker is
permitted to convert anything relocated with R_ARM_CALL to a "BLX"
which would be flat-out wrong for a "B". It also says that R_ARM_PLT32
is deprecated in favour of R_ARM_JUMP24 (etc) so the PCRel changes
should be correct. Tested too.

You can commit as far as I'm concerned (whatever that counts for).

Tim.