[llvm-commits] PATCH: Adding accessors to llvm::Object:COFFObjectFile

Michael Spencer bigcheesegs at gmail.com
Mon Jun 18 12:15:49 PDT 2012


On Sun, Jun 17, 2012 at 10:25 PM, Marshall Clow <mclow.lists at gmail.com> wrote:
> On Jun 14, 2012, at 5:35 PM, Michael Spencer wrote:
>> On Thu, Jun 14, 2012 at 5:16 PM, Marshall Clow <mclow.lists at gmail.com> wrote:
>>> So that clients can (if they need to) get at the underlying structures in the file
>>>
>>> Adds three new routines:
>>>
>>> getCOFFSection, getCOFFSymbo and getSymbolAuxData
>
>
> I missed one -
>     const coff_relocation *getCOFFRelocation(relocation_iterator &It) const;
>
> It turns out that relocation_iterator was missing:
>        DataRefImpl getRawDataRefImpl() const;
>
> so I added that too.
>
> -- Marshall
>
> Marshall Clow     Idio Software   <mailto:mclow.lists at gmail.com>
>
> A.D. 1517: Martin Luther nails his 95 Theses to the church door and is promptly moderated down to (-1, Flamebait).
>        -- Yu Suzuki
>

+const coff_relocation
*COFFObjectFile::getCOFFRelocation(relocation_iterator &It) const {
+  return toRel(It->getRawDataRefImpl());
+}

80-col. Other than that it's fine.

- Michael Spencer




More information about the llvm-commits mailing list