[llvm-commits] [llvm] r158638 - in /llvm/trunk: include/llvm/ADT/DenseMap.h unittests/ADT/DenseMapTest.cpp

[David Blaikie]

On Mon, Jun 18, 2012 at 8:37 AM, Duncan Sands <baldrick at free.fr> wrote:
> Hi Chandler,
>
>> The codebase already has piles of these incorrect warnings in it,
>
> maybe clang does but LLVM proper does not, so why not keep it that way?

Indeed, the buildbots show about 5-10 of these across LLVM and Clang -
I've fixed several legitimate bugs with this warning and I could
justify fixing at least half of the remaining buildbot GCC warnings
(most of which are this particular kind) as removing reliance on UB.
(probably the biggest false positive problem is that GCC assumes a
switch over enum isn't covered just because it covers all enum values
(since it could have values in the representable range but outside the
enum values))

Though I do appreciate that it's a rather annoyingly unhelpful warning
in terms of providing the necessary information to resolve the issues
it finds.

- David

>
> Ciao, Duncan.
>
>  and they're
>> not likely to be fixed. My suggestion? Use clang. ;] It's -Wuninitialized
>> doesn't have this problem.
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits