[llvm-commits] [llvm] r158457 - /llvm/trunk/include/llvm/ADT/FlatArrayMap.h

[Stepan Dyatkovskiy]

This is really not very good. Can you show some example that will work 
improperly in SmallMap?
-Stepan.
Chandler Carruth wrote:
> On Thu, Jun 14, 2012 at 10:21 AM, Stepan Dyatkovskiy <stpworld at narod.ru
> <mailto:stpworld at narod.ru>> wrote:
>
>     Oh... Thanks, Ben. I'll fix it. But I can do it at 21st June only :-(
>
>
> Don't worry about it.
>
> Sadly, this doesn't really address all of the issues. The destructors
> are still not run consistently, nor are the constructors, and there are
> some initialization issues.
>
> I've almost finished implementing a correct SmallDenseMap that will be
> able to handle all of these aspects, and will also be slightly more
> efficient.
>
> I'm planning to send it out for review today, and hopefully check it in
> and replace all uses of SmallMap with it.