[llvm-commits] LLD PATCH: add ELF reader basic skeleton code

[Evandro Menezes]

Nick,

On 06/14/12 13:12, Nick Kledzik wrote:
> +	//	 FIXME What distinguishes a symbol in ELF that can help
> +	//	 decide if the symbol is undefined only during build and not
> +	//	 runtime? This will make us choose canBeNullAtBuildtime and
> +	//	 canBeNullAtRuntime
 >
> My understanding is that __attribute__((weak)) in C, leads to canBeNullAtBuildtime.

A weak symbol can be null both at build-time and at run-time.  Do both 
canBeNullAtBuildtime and canBeNullAtRuntime exist for when an undefined 
canBeNullAtBuildtime symbol may be removed?

> +	//	 Many non ARM architectures use ELF file format
> +	//	 This not really a place to put a architecture
> +	//	 specific method in an atom. A better approach is
> +	//	 needed.
> +	//
>
> Yes.  I'm sure there are other CPU specific attributes.  We need to figure out a generic way to handle these.

Perhaps the target could be given a chance to optionally qualify an atom 
in any way it wants.  But this method in particular, isThumb(), 
shouldn't this check be part of the ARM-specific functions instead of 
the target-independent API?

-- 
Evandro Menezes          Austin, TX          emenezes at codeaurora.org
Qualcomm Innovation Center, Inc is a member of the Code Aurora Forum