[llvm-commits] Remove internal fault in ARM assembler

Richard Barton richard.barton at arm.com
Wed Jun 13 09:51:43 PDT 2012


Hello Reviewers

Our testing has turned up an assertion failure in the MC Assembler for CPS
instructions.

The assembly string that causes the error is a non-interrupt affecting CPS with
an interrupt flag set (e.g. CPS f,#1)

This is not legal assembly, but the instruction is unpredictable, so there is no
restriction on assembly representation. The MC assembler should not abort on any
input, but should fail with an error message.

The attached patch replaces the internal fault with an error message, and adds a
test.

Please review

Regards,

Richard Barton
ARM Ltd, Cambridge
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cps_asm_parser_abort.patch
Type: application/octet-stream
Size: 1262 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120613/f32604ca/attachment.obj>


More information about the llvm-commits mailing list