[llvm-commits] [PATCH] Fix sext(setcc(N0 cc N0)) for vectors

Duncan Sands baldrick at free.fr
Wed Jun 13 04:43:32 PDT 2012

Hi James,

> We were emitting 0/1 booleans, instead of 0/-1 booleans.
> Ran full test suite to ensure no regressions.

+++ b/test/CodeGen/Generic/sext-setcc-self.ll
@@ -0,0 +1,76 @@
+; RUN: %lli %s | grep {^0xFFFFFFFF 0xFFFFFFFF 0xFFFFFFFF 0xFFFFFFFF$}

I'm pretty sure you aren't supposed to be executing code like this in the
regression testsuite, instead you should do pattern matching.  Code to be
executed belongs in the nightly testsuite.  I could be wrong about this,
but I think it's the policy.

Ciao, Duncan.

PS: Otherwise it looks OK.

More information about the llvm-commits mailing list