[llvm-commits] [cfe-commits] TableGen backend API refactoring review request

[Jakob Stoklund Olesen]

On Jun 8, 2012, at 10:33 PM, Sean Silva <silvas at purdue.edu> wrote:

> Ok, these patches address all of your points.
> 
> 1-llvm.patch is the initial changes to the llvm tree. It changes the backend api for llvm/utils/TableGen/* and it makes some very minor non-breaking changes to include/llvm/TableGen/TableGenBackend.h and lib/TableGen/TableGenBackend.h be make emitSourceFileHeader available as a free function (the member function still exists to not break Clang's TableGen)
> 2-clang.patch changes Clang's TableGen to the new API
> 3-llvm.patch removes struct TableGenBackend and all remnants of the old API.

Almost there. Please make sure all classes are in anonymous namespaces, and read this:

http://llvm.org/docs/CodingStandards.html#micro_anonns

> I built `check` and `clang-test` after applying each one against ToT of the respective repos; all green.

Please verify that no .inc files change content wih these patches.

/jakob