[llvm-commits] [PATCH] Make SimplifyCFGPass preserve the dominator tree

Evan Cheng evan.cheng at apple.com
Fri Jun 8 14:29:23 PDT 2012


This seems obviously correct / better. But is it too much to hope for incremental updates of dominator info?

Evan

On Jun 8, 2012, at 10:47 AM, Peter Cooper <peter_cooper at apple.com> wrote:

> Hi all
> 
> Attached is a pass to make the SimplifyCFGPass preserve the dominator tree.  Currently we see lots of recalculations of the dom tree right after simplify cfg runs, regardless of whether simplify cfg actually did anything.
> 
> This pass explicitly recalculates the dom tree if simplify cfg did anything, but otherwise just leaves it preserved so we recalculate less often.
> 
> Also, i'm open to suggestions for a better way to do this.  Ideally the pass manager could track this but not all passes return true from their run functions when they actually make a change.
> 
> Thanks,
> Pete
> <simplifycfg.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list