[llvm-commits] [llvm] r158160 - /llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

[Chandler Carruth]

On Thu, Jun 7, 2012 at 4:33 PM, Manman Ren <mren at apple.com> wrote:

>
> I tried using bugpoint to reduce PR13046.
> Attached is what bugpoint generated.
>
> Not sure whether I should add this as a test case.
>

You should add something as a test case at leastw. ;]

You can hand reduce this further, removing metadata, comments, making the
names shorter and more test-case-y. You may even be able to delete a few
more basic blocks by re-arranging things in ways bugpoint doesn't try. But
it's already pretty reasonable, so don't drive yourself batty trying to
further reduce the test case. I think with at least some manual cleanup,
this will make a fine addition to the test suite. Ideally add it to the
existing tests for this optimization.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120607/3d9dd599/attachment.html>