[llvm-commits] [llvm] r158160 - /llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

[Manman Ren]

Author: mren
Date: Thu Jun  7 14:27:33 2012
New Revision: 158160

URL: http://llvm.org/viewvc/llvm-project?rev=158160&view=rev
Log:
PR13046: we can't replace usage of SUB with CMP in the lowering phase.

It will cause assertion failure later on.

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=158160&r1=158159&r2=158160&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Thu Jun  7 14:27:33 2012
@@ -8306,7 +8306,8 @@
   if (Opcode == X86ISD::CMP) {
     SDValue New = DAG.getNode(Opcode, dl, MVT::i32, Op.getOperand(0),
                               Op.getOperand(1));
-    DAG.ReplaceAllUsesWith(Op, New);
+    // We can't replace usage of SUB with CMP.
+    // The SUB node will be removed later because there is no use of it.
     return SDValue(New.getNode(), 0);
   }