[llvm-commits] [LLVMdev] [PATCH] Remove instruction within a bundle

[Andrew Trick]

On Jun 5, 2012, at 12:43 AM, Ivan Llopard <ivanllopard at gmail.com> wrote:

> Hi again!
> 
> I don't know if I should send patches for review to llvmdev or llvmcommits so I forward my original message sent to llvmdev.
> 
> Thanks,
> Ivan
> 
> 
> -------- Original Message --------
> Subject:	[LLVMdev] [PATCH] Remove instruction within a bundle
> Date:	Sun, 03 Jun 2012 17:17:47 +0200
> From:	Ivan Llopard <ivanllopard at gmail.com>
> To:	LLVM Developers Mailing List <llvmdev at cs.uiuc.edu>
> 
> Hi,
> 
> I've raised an assertion when I tried to remove an instruction within a 
> bundle by calling eraseFromParent(). It seems that in order to erase the 
> MI, a bundle iterator is created but it's forbidden if the MI is not the 
> bundle's header. The attached patch fix it.
> As a test case, call eraseFromParent() on a machine instruction with its 
> isInsideBundle flag activated.
> 
> Ivan

llvm-commits is the place for patches.

I committed this with a comment in r158025.

I realize it's nearly impossible to come up with a unit test. I was hoping to create a testing mode for MachineInstrBundles but never got to it. Contributions welcome.

-Andy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120605/8d104684/attachment.html>