[llvm-commits] Add ASan option "use_internal_symbolizer" (issue 6277044)

kcc at google.com kcc at google.com
Mon Jun 4 03:27:21 PDT 2012


http://codereview.appspot.com/6277044/diff/1/asan_rtl.cc
File asan_rtl.cc (right):

http://codereview.appspot.com/6277044/diff/1/asan_rtl.cc#newcode55
asan_rtl.cc:55: bool    FLAG_use_internal_symbolizer = 0;
we already have FLAG_symbolize for exactly this purpose.

http://codereview.appspot.com/6277044/diff/1/asan_stack.cc
File asan_stack.cc (right):

http://codereview.appspot.com/6277044/diff/1/asan_stack.cc#newcode56
asan_stack.cc:56: Printf("    #%zu 0x%zx %s:%d:%d\n", frame_num++, pc,
i'd prefer to have frame_num++ in a separate line

http://codereview.appspot.com/6277044/diff/1/asan_stack.cc#newcode65
asan_stack.cc:65: Printf("    #%zu 0x%zx (%s+0x%zx)\n", frame_num++, pc,
filename,
same here, or just use 'i'

http://codereview.appspot.com/6277044/



More information about the llvm-commits mailing list