[llvm-commits] [PATCH] De-dupe llvm.global_dtors append logic in ProfilingUtils.cpp

[Rafael Espíndola]

LGTM

On 19 May 2012 14:22, Matt Johnson <johnso87 at crhc.illinois.edu> wrote:
> Ping?  The original patch still applies cleanly to ToT :)
> Thanks,
> Matt
>
> On 05/05/2012 03:21 PM, Matt Johnson wrote:
>> The profiling code has a helper function to append a user-specified
>> Function* to llvm.global_dtors. There's a helper function to do the same
>> in Transforms/Utils/ModuleUtils.h. The attached patch refactors
>> ProfilingUtils.cpp to use the helper instead.
>>
>> There are no test cases for GCOV profiling (the only client of the
>> refactored function) that I can find, so I ran a couple examples by
>> hand, and the patched version's instrumented IR matches the original.
>> The patched version also passes make check-all like the original.
>>
>> -Matt
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits