[llvm-commits] [cfe-commits] [PATCH] Add llvm.fmuladd intrinsic.

[Lang Hames]

Hi All,

"Thanks for the suggestion Matthieu. I spoke to Doug and he recommended
using attributes rather than a FunctionDecl bit to represent the
fp_contract state. This patch is a first attempt at that. Please review and
let me know what I've missed, or what could be done better.

Cheers,
Lang.

On Wed, May 30, 2012 at 11:14 AM, Matthieu Monrocq <
matthieu.monrocq at gmail.com> wrote:

>
>
> On Wed, May 30, 2012 at 9:20 AM, Lang Hames <lhames at gmail.com> wrote:
>
>> Agreed - Legal was a poor choice of terms. I don't know if we want to
>>> check TLI.isOperationLegal(...) though - an llvm.fma.* call (which is what
>>> we lower to) will always be legal...
>>>
>>
>> Owen pointed out that I'm finding new and interesting ways to abuse the
>> term 'legal' here. To clarify: If isFMACheap returns true we should
>> legalize the llvm.fmuladd.* to an llvm.fma.* and leave it to the existing
>> legalization code to turn the llvm.fma.* into something sane for the target.
>>
>> - Lang.
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>>
> Hello Lang,
>
> I only have one nits: I think you'll need Doug's approval for adding a bit
> flag into FunctionDecl (especially since this is such a specialized
> construct).
>
> I added him in case he missed the discussion.
>
> -- Matthieu
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120531/4707282c/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang-fp-contract-fmuladd-codgen-2.patch
Type: application/octet-stream
Size: 5126 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120531/4707282c/attachment.obj>