[llvm-commits] Bug in promoting types in RetCC

[Jakob Stoklund Olesen]

On May 31, 2012, at 9:19 AM, Yiannis Tsiouris <gtsiour at softlab.ntua.gr> wrote:

> On 05/25/2012 02:22 PM, Yiannis Tsiouris wrote:
>> On 05/25/2012 01:54 AM, Jakob Stoklund Olesen wrote:
>>> On 05/21/2012 02:20 AM, Yiannis Tsiouris wrote:
>>>>> Hi,
>>>>> 
>>>>> As discussed in this thread [1, 2], there seems to be a bug in promoting
>>>>> types in a RetCC. The attached patch fixes this. There is no unit-test
>>>>> attached because no RetCC uses CCPromoteToType nowadays. I noticed this
>>>>> trying to write a unit-test for a patch that inserts custom prologue
>>>>> code for the HiPE compiler (to be submitted for review as soon as the
>>>>> HiPE CC patch is accepted).
>>>>> 
>>>>> If there is something wrong in the attached patch or the patch in [1],
>>>>> please let me know! :-)
>>> The patch appears to break most of the X86 unit tests.
>>> 
>>> /jakob
>> Sorry, for that! The attached should work.
>> 
>> ~y.
> Ping.
> Re-attached patch for conveniency.

r157757

/jakob