[llvm-commits] PATCH: Stub for ASan/TSan symbolizer

[Dmitry Vyukov]

On Thu, May 31, 2012 at 3:31 PM, Chandler Carruth <chandlerc at google.com>wrote:

> What's the goal of this stub? Why is it needed, and how will it fit into
> the bigger picture?
>
> You use '__' in an identifier -- that's not allowed outside of the
> standard library.
>


I would prefer to conflict with standard library/language impl rather than
with user code - there are much more user code.



>
> Also, you have comments that don't agree with the file names, and comments
> that don't make a lot af sense (Why is including system headers bad? What
> is mini_libc?). It almost looks like this is cribbed from some other
> codebase???
>
> On Thu, May 31, 2012 at 4:22 AM, Alexey Samsonov <samsonov at google.com>wrote:
>
>> Hi,
>>
>> This patch adds a stub for LLVM-based symbolizer that is intended to be
>> used in {Address,Thread}Sanitizer.
>>
>> --
>> Alexey Samsonov, MSK
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120531/ca0592b4/attachment.html>