[llvm-commits] [compiler-rt] r157584 - /compiler-rt/trunk/lib/tsan/rtl/tsan_rtl_thread.cc

[Dmitry Vyukov]

Author: dvyukov
Date: Mon May 28 12:32:50 2012
New Revision: 157584

URL: http://llvm.org/viewvc/llvm-project?rev=157584&view=rev
Log:
tsan: fix race during pthread_join/detach

Modified:
    compiler-rt/trunk/lib/tsan/rtl/tsan_rtl_thread.cc

Modified: compiler-rt/trunk/lib/tsan/rtl/tsan_rtl_thread.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_rtl_thread.cc?rev=157584&r1=157583&r2=157584&view=diff
==============================================================================
--- compiler-rt/trunk/lib/tsan/rtl/tsan_rtl_thread.cc (original)
+++ compiler-rt/trunk/lib/tsan/rtl/tsan_rtl_thread.cc Mon May 28 12:32:50 2012
@@ -226,15 +226,20 @@
 
 int ThreadTid(ThreadState *thr, uptr pc, uptr uid) {
   CHECK_GT(thr->in_rtl, 0);
-  DPrintf("#%d: ThreadTid uid=%lu\n", thr->tid, uid);
-  Lock l(&CTX()->thread_mtx);
+  Context *ctx = CTX();
+  Lock l(&ctx->thread_mtx);
+  int res = -1;
   for (unsigned tid = 0; tid < kMaxTid; tid++) {
-    if (CTX()->threads[tid] != 0
-        && CTX()->threads[tid]->user_id == uid
-        && CTX()->threads[tid]->status != ThreadStatusInvalid)
-      return tid;
+    ThreadContext *tctx = ctx->threads[tid];
+    if (tctx != 0 && tctx->user_id == uid
+        && tctx->status != ThreadStatusInvalid) {
+      tctx->user_id = 0;
+      res = tid;
+      break;
+    }
   }
-  return -1;
+  DPrintf("#%d: ThreadTid uid=%lu tid=%d\n", thr->tid, uid, res);
+  return res;
 }
 
 void ThreadJoin(ThreadState *thr, uptr pc, int tid) {