[llvm-commits] [PATCH] Move the implementation of LoopInfo into LoopInfoImpl.h.

[Andrew Trick]

On May 24, 2012, at 10:15 PM, Chandler Carruth <chandlerc at google.com> wrote:

> On Thu, May 24, 2012 at 10:11 PM, Andrew Trick <atrick at apple.com> wrote:
> I'd like to move the loop discovery algorithm out of the main header before I start changing it.
> 
> This makes the LoopInfo interface readable, which I think is extremely important.
> 
> Bonus:
> While I'm working on it, it speeds up my rebuilds by 4.7x.
> And for everyone else working outside LoopInfo, well your builds could be a full second faster ;-)
> 
> We've been using the same explicit instantiation strategy in BlockFrequency for a year now and no one has complained. But I thought wait for feedback anyway--hopefully just doxygen nits!
> 
> If the strategy is to use explicit instantiation only, why not move it completely into a .cc file?

I'll follow any convention you like if you can be more specific. LoopInfo.cpp and MachineLoopInfo.cpp are the placeholders that determine which library contains the instantiations.

-Andy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120524/5735fad7/attachment.html>