[llvm-commits] APInt::sdivrem fix

[Nuno Lopes]

Hi,

I just committed a modified version of your patch:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120521/143182.html

Next time please make sure that the patch you send actually compiles  
and that all tests pass.  The unit test patch you sent didn't compile  
and it didn't pass.

Thanks,
Nuno


Citando Nuno Lopes <nunoplopes at sapo.pt>:

> The patch looks good to me (modulo the tabs in the APInt.h file).
> Please go ahead and commit it.
>
> Nuno
>
>
> Citando Preston Briggs <preston.briggs at gmail.com>:
>
>> The code for APInt.sdivrem is currently incorrect, mishandling things like
>>
>> *sdivrem(-9, -1) => (-9, 0)*
>>
>> *
>> *
>> Attached are patches for APInt.h and APIntTest.cpp
>>
>> Could someone review it and check it in?
>>
>> Thanks,
>> Preston