[llvm-commits] [llvm] r157035 - /llvm/trunk/test/ExecutionEngine/MCJIT/lit.local.cfg

[Eric Christopher]

Yeah, the problem is that they should still work for 64-bit even if they aren't for 32-bit. MCJIT is most assuredly supported on darwin.

-eric

On May 17, 2012, at 8:58 PM, Danil Malyshev wrote:

> Hi Eric,
> 
> Unfortunately, I could not now completely solve all the problems with the relocations in the darwin 32bit.
> However, I did not revert the MCJIT test patches, because they works fine in the platforms that are supported by MCJIT. And these tests skips fine in platforms that are not supported by MCJIT, like for darwin now.
> I think switch on these tests for a platform after it will be supported by MCJIT is much better than haven't any MCJIT tests.
> 
> Regards,
> Danil
> 
> ________________________________________
> From: Eric Christopher [echristo at apple.com]
> Sent: Thursday, May 17, 2012 5:51 PM
> To: Danil Malyshev
> Cc: llvm-commits at cs.uiuc.edu; , Anna Zaks
> Subject: Re: [llvm-commits] [llvm] r157035 - /llvm/trunk/test/ExecutionEngine/MCJIT/lit.local.cfg
> 
> If you don't finish it today there's nothing wrong with reverting your patch and re-enabling it when everything else is fixed up.
> 
> To be clear: if you don't finish it please revert both of your patches and pick it up again tomorrow :)
> 
> Thanks!
> 
> -eric
> 
> On May 17, 2012, at 5:49 PM, Danil Malyshev <dmalyshev at accesssoftek.com> wrote:
> 
>> Hi Eric,
>> 
>> I'm working with it right now, and hope to finish it today.
>> 
>> 
>> Regards,
>> Danil
>> 
>> ________________________________________
>> From: Eric Christopher [echristo at apple.com]
>> Sent: Thursday, May 17, 2012 5:35 PM
>> To: Danil Malyshev
>> Cc: llvm-commits at cs.uiuc.edu
>> Subject: Re: [llvm-commits] [llvm] r157035 - /llvm/trunk/test/ExecutionEngine/MCJIT/lit.local.cfg
>> 
>> On May 17, 2012, at 5:30 PM, Danil Malyshev <dmalyshev at accesssoftek.com> wrote:
>> 
>>> Author: danil
>>> Date: Thu May 17 19:30:58 2012
>>> New Revision: 157035
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=157035&view=rev
>>> Log:
>>> Temporarily disabled the MCJIT tests for Darwin, because the RuntimeDyldMachO has a problems with relocations for 32bit x86.
>> 
>> I don't think this is the right way to deal with it. What is your current plan for fixing and re-enabling?
>> 
>> -eric